Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: next example now works #652

Merged
merged 4 commits into from
Jun 29, 2023
Merged

fix: next example now works #652

merged 4 commits into from
Jun 29, 2023

Conversation

multivoltage
Copy link
Contributor

Fixed

For my previus PR I noticed that nextjs did not work since it use a different react version.
I fixed using same version.

@changeset-bot
Copy link

changeset-bot bot commented Jun 26, 2023 •
edited
Loading

⚠️ No Changeset found

Latest commit: e040edd

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

devrnt
devrnt reviewed Jun 26, 2023
View reviewed changes
Copy link
Owner

@devrnt devrnt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks man! I've 1 question, see review

pnpm-lock.yaml Outdated Show resolved Hide resolved
@devrnt
Copy link
Owner

devrnt commented Jun 26, 2023

I ran this locally and seems like this is still not working

@multivoltage
Copy link
Contributor Author

What task did you run?

@multivoltage
Copy link
Contributor Author

@devrnt
I installed [email protected] and reverted these 4 lines.
Then I Run "build" "build-playground" and "test" without error.

@devrnt
Copy link
Owner

devrnt commented Jun 28, 2023

I'm running the dev:examples script. Seems like there are 2 versions of React in the nextjs example

@multivoltage
Copy link
Contributor Author

I don't know.
Before my commit there was 2 version of react between next and gatasby. Now There is only 18.2.0.
I delete and clone again my branch.
Run:
pnpm run install, pnpm run dev, pnpm run dev-examples, pnpm run build.
All these task finish ok in my local ;(

devrnt
devrnt requested changes Jun 28, 2023
View reviewed changes
Copy link
Owner

@devrnt devrnt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My bad, had to do a clean re-install of my dependencies. Seems to work fine. Just one more thing

apps/examples/nextjs/package.json Outdated Show resolved Hide resolved
@devrnt devrnt merged commit 8634b04 into devrnt:main Jun 29, 2023
@devrnt
Copy link
Owner

devrnt commented Jun 29, 2023

Big thanks!

@multivoltage multivoltage deleted the fix/working-next-example branch June 29, 2023 19:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@devrnt devrnt devrnt approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@multivoltage @devrnt